bpo-25324: Move the description of tokenize tokens to token.rst.#1911
Merged
serhiy-storchaka merged 2 commits intopython:masterfrom Jun 6, 2017
Merged
bpo-25324: Move the description of tokenize tokens to token.rst.#1911serhiy-storchaka merged 2 commits intopython:masterfrom
serhiy-storchaka merged 2 commits intopython:masterfrom
Conversation
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @benjaminp and @vadmium to be potential reviewers. |
vadmium
reviewed
Jun 3, 2017
| Added :data:`COMMENT`, :data:`NL` and :data:`ENCODING` to bring | ||
| the tokens in the C code in line with the tokens needed in | ||
| :mod:`tokenize` module. These tokens aren't used by the C tokenizer. No newline at end of file | ||
| Following token type values aren't used by the C tokenizer but are needed for |
Member
There was a problem hiding this comment.
Add the in front: The following token type values . . .
Member
Author
|
Thank you for your review @vadmium. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also tweaks the formatting.